Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset #2

[Oliver Neukum]

Am Samstag 28 Juni 2008 17:03:45 schrieb Alfred E. Heggestad:
 
Hello,

> many many thanks for your patch and your suggested code improvements.
> I have tested your patch and I have some comments:
> 
> * The first version of your patch was tested, and it applied cleanly
>    and compiled with out any errors. The module was loaded OK, but when
>    I inserted the CM109-device into the USB-port, the machine crashed.
>    I fixed that issue by adding this to the usb_probe() function:
> 
> 	init_waitqueue_head(&dev->wait);

Sorry about that.

> * The second version of your patch was applied with some local mods.
>    This is now working as expected.

Good.

> * I have tested suspend/resume with 2.6.25.9 and TuxOnIce 3.0-rc7
>    and it works fine (cm109 device was plugged in during suspend).
>    During suspend I get this in syslog:
> 
>      drivers/input/misc/cm109.c: cm109: usb_suspend (event=1)
>      drivers/input/misc/cm109.c: urb_irq_callback: urb status -2

That is normal. It indicates that usb_kill_urb() had terminated the URB.
Which logging level did you use?

> * The flag "char disconnecting:1" is no longer used in your second
>    patch, and has been removed from the struct.

Sorry again.

> * When the buzzer is triggered by SND_TONE/SND_BELL, I get these
>    warnings in syslog:
> 
>      drivers/input/misc/cm109.c: urb_ctl_callback: usb_submit_urb failed -22
>      drivers/input/misc/cm109.c: buzz: usb_submit_urb failed -22
>      drivers/input/misc/cm109.c: urb_ctl_callback: usb_submit_urb failed -22
>      drivers/input/misc/cm109.c: buzz: usb_submit_urb failed -22
> 
>    It seems that the ctl URB is shared between buzzer and keypress
>    handling. I am thinking about adding a new URB just for the buzzer,
>    but I am not sure if that really is necesary. Any suggestions?

Under which conditions did you get this? Was the device opened or not?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/