Re: [PATCH 9/13] viafb: Makefile, share.h

[Sam Ravnborg]

On Mon, Jun 30, 2008 at 03:38:52PM +0800, JosephChan@xxxxxxxxxx wrote:
> Makefile for drivers/video/via/ 
> share.h: shared macro for viafb
> 
> 
> Signed-off-by: Joseph Chan <josephchan@xxxxxxxxxx>
> 
> diff -Nur a/drivers/video/via/Makefile b/drivers/video/via/Makefile
> --- a/drivers/video/via/Makefile	1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/Makefile	2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,9 @@
> +#
> +# Makefile for the VIA framebuffer driver (for Linux Kernel 2.6)
> +#
> +                                                                                
> +obj-$(CONFIG_FB_VIA) += viafb.o
> +
> +viafb-y	:=viafbdev.o hw.o iface.o  via_i2c.o dvi.o lcd.o ioctl.o accel.o via_utility.o vt1636.o global.o tblDPASetting.o viamode.o tbl1636.o
> +
> +viafb-objs	:=	$(viafb-y)

This assignmnet is not needed - please drop it.
kbuild already understands <modulename>-y

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/