Re: [PATCH V2] Keep 3 high personality bytes across exec

[Paul Mackerras]

Eric B Munson writes:

> --- a/include/asm-powerpc/elf.h
> +++ b/include/asm-powerpc/elf.h
> @@ -257,7 +257,8 @@ do {								\
>  	else							\
>  		clear_thread_flag(TIF_ABI_PENDING);		\
>  	if (personality(current->personality) != PER_LINUX32)	\
> -		set_personality(PER_LINUX);			\
> +		set_personality(PER_LINUX |			\
> +			(current->personality & PER_INHERIT));	\

Couldn't we use ~PER_MASK here instead of PER_INHERIT?  That would
mean we wouldn't have to modify include/linux/personality.h, and we
wouldn't have to keep updating PER_INHERIT as more flags get added.

(Nice patch description, BTW.  Thanks.)

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/