Re: [PATCH] memcg: mem_cgroup_shrink_usage css_put

From: KAMEZAWA Hiroyuki
Date: Sun Jun 29 2008 - 22:21:37 EST


On Sun, 29 Jun 2008 01:15:38 +0100 (BST)
Hugh Dickins <hugh@xxxxxxxxxxx> wrote:

> mem_cgroup_shrink_usage makes no charge: balance its css_get with a css_put.
>
> Signed-off-by: Hugh Dickins <hugh@xxxxxxxxxxx>

Sorry for my mistakes

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>


> ---
> Should follow mmotm's memcg-helper-function-for-relcaim-from-shmem.patch
>
> mm/memcontrol.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm/mm/memcontrol.c 2008-06-27 13:39:20.000000000 +0100
> +++ linux/mm/memcontrol.c 2008-06-27 17:32:29.000000000 +0100
> @@ -801,6 +801,7 @@ int mem_cgroup_shrink_usage(struct mm_st
> progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> } while (!progress && --retry);
>
> + css_put(&mem->css);
> if (!retry)
> return -ENOMEM;
> return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/