Re: [v4l-dvb-maintainer] [PATCH] add Sensoray 2255 v4l driver

[hermann pitton]

Am Samstag, den 28.06.2008, 08:31 -0300 schrieb Mauro Carvalho Chehab:
> On Thu, 26 Jun 2008 16:15:51 -0700
> Greg KH <greg@xxxxxxxxx> wrote:
> 
> > From: Dean Anderson <dean@xxxxxxxxxxxx>
> > 
> > This driver adds support for the Sensoray 2255 devices.
> > 
> > It was primarily developed by Dean Anderson with only a little bit of
> > guidance and cleanup by Greg.
> > 
> 
> Hmm... there are still a few minor CodingStyle errors:
> 
> ERROR: return is not a function, parentheses are not required
> #881: FILE: drivers/media/video/s2255drv.c:792:
> +       return (dev->resources[fh->channel]);
> 
> WARNING: line over 80 characters
> #898: FILE: drivers/media/video/s2255drv.c:809:
> +       strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));
> 
> ERROR: return is not a function, parentheses are not required
> #932: FILE: drivers/media/video/s2255drv.c:843:
> +       return (0);
> 
> ERROR: return is not a function, parentheses are not required
> #1053: FILE: drivers/media/video/s2255drv.c:964:
> +               return (ret);
> 
> ERROR: return is not a function, parentheses are not required
> #1428: FILE: drivers/media/video/s2255drv.c:1339:
> +       return (0);
> 
> ERROR: return is not a function, parentheses are not required
> #1452: FILE: drivers/media/video/s2255drv.c:1363:
> +                       return (0);
> 
> ERROR: return is not a function, parentheses are not required
> #1467: FILE: drivers/media/video/s2255drv.c:1378:
> +                       return (0);
> 
> ERROR: return is not a function, parentheses are not required
> #1487: FILE: drivers/media/video/s2255drv.c:1398:
> +                               return (-ERANGE);
> 
> total: 7 errors, 1 warnings, 2508 lines checked
> 
> I'm applying the patch right now on my tree.
> 
> Dean,
> 
> When you have some time, please send me a patch fixing those.
> 
> heers,
> Mauro
> 

On an attempt to get recent drivers on a FC8 x86_64 machine to watch
Glastonbury music festival on BBC HD DVB-S with the saa714 driver on an
recently updated 2.6.25 FC kernel it also fails to compile on some
strlcpy attempt. Same with a 2.6.24 on the mail machine here.

  CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/quickcam_messenger.o
  CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.o
/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c: In function 'vidioc_querycap':
/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: error: implicit declaration of function 'dev_name'
/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: warning: passing argument 2 of 'strlcpy' makes pointer from integer without a cast
make[3]: *** [/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.o] Error 1
make[2]: *** [_module_/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l] Error 2
make[2]: Leaving directory `/usr/src/kernels/2.6.24.7-92.fc8-i686'
make[1]: *** [default] Fehler 2
make[1]: Leaving directory `/mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l'
make: *** [all] Fehler 2

Cheers,
Hermann



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/