Re: [PATCH 1/3] sched: fix TASK_WAKEKILL vs SIGKILL race

From: Roland McGrath
Date: Fri Jun 27 2008 - 16:52:35 EST


I was also concerned about perturbing the schedule() hot path with the
original patch. With this version making signal_pending_state() inline,
I think it's good.

> Note this "__TASK_STOPPED | __TASK_TRACED" check in signal_pending_state().
> This is needed to preserve the current behaviour (ptrace_notify). I hope
> this check will be removed soon, but this (afaics good) change needs the
> separate discussion.

Agreed. I think it might actually already be safe to drop it, but we can
get to that after this settles.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/