Re: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible forAVR32 users

From: Adrian Bunk
Date: Fri Jun 27 2008 - 14:31:28 EST


On Fri, Jun 27, 2008 at 11:24:42AM -0700, David Brownell wrote:
> On Friday 27 June 2008, Adrian Bunk wrote:
> > The only effect of the HAVE_DMA_ENGINE would be to not show an empty
> > kconfig menu.
>
> Well, no. It would also make the network layer memcpy "acceleration"
> option unavailable when there was no underlying engine ... similarly
> with other pointless "we don't have that subsystem here" options.
>...

This NET_DMA issue has already been fixed 11 months ago - in the same
patch that added the arch dependency for the menu. [1]

NET_DMA now depends on DMA_ENGINE which gets select'ed by the device
options. NET_DMA can therefore never be offered on architectures
without any DMA device.

cu
Adrian

[1] http://lkml.org/lkml/2007/7/26/15

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/