Re: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible forAVR32 users

[Adrian Bunk]

On Fri, Jun 27, 2008 at 09:37:21AM -0700, David Brownell wrote:
> On Thursday 26 June 2008, Dan Williams wrote:
> > I agree with removing the arch dependency, and I do not think we
> > necessarily need to add HAVE_DMA_ENGINE.
> 
> I think a HAVE_DMA_ENGINE would be better than what you're doing
> below:  moving the arch dependency into the network code, and
> adding this !HIGHMEM64G thing (which is really just a more subtle
> arch dependency).
>...

The only effect of the HAVE_DMA_ENGINE would be to not show an empty 
kconfig menu.

That's IMHO too much effort for a purely cosmetical kconfig issue.

And I speak as the one who originally added the arch dependency...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/