Re: [PATCH 00/34] AMD IOMMU driver

From: Ingo Molnar
Date: Fri Jun 27 2008 - 06:08:33 EST



-tip testing found a build failure with:

arch/x86/kernel/amd_iommu_init.c:247: warning: 'struct acpi_table_header' declared inside parameter list
arch/x86/kernel/amd_iommu_init.c:247: warning: its scope is only this definition or declaration, which is probably not what you want
arch/x86/kernel/amd_iommu_init.c: In function 'find_last_devid_acpi':
arch/x86/kernel/amd_iommu_init.c:257: error: dereferencing pointer to incomplete type

http://redhat.com/~mingo/misc/config-Fri_Jun_27_10_29_06_CEST_2008.bad

this is due to !CONFIG_ACPI.

since AMD IOMMU discovery depends on ACPI anyway, i've fixed this in the
Kconfig space. (Eventually, if you want to make it directly discoverable
via the PCI space in the future, you might want to fix this dependency.)

i've pushed out the fix below into -tip.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/