Re: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup

From: KOSAKI Motohiro
Date: Fri Jun 27 2008 - 01:42:25 EST


> > mem_cgroup_uncharge() against old page is done after radix-tree-replacement.
> > And there were special handling to ingore swap-cache page. But, shmem can
> > be swap-cache and file-cache at the same time. Chekcing PageSwapCache() is
> > not correct here. Check PageAnon() instead.
>
> When/How shmem can be both swap-cache and file-cache ?
> I can't understand that situation.

Hi

see,

shmem_writepage()
-> add_to_swap_cache()
-> SetPageSwapCache()


BTW: his file-cache mean !Anon, not mean !SwapBacked.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/