Re: [PATCH 00/16] x86: merge setup_32/64.c

From: Ingo Molnar
Date: Thu Jun 26 2008 - 06:02:29 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> x86: rename setup.c to setup_percpu.c

this brought a build failure:

arch/x86/kernel/setup.c: In function âsetup_arch':
arch/x86/kernel/setup.c:561: error: implicit declaration of function âefi_reserve_early'

09865f3049050458a5c236e5b4630f137d9b179d is first bad commit
commit 09865f3049050458a5c236e5b4630f137d9b179d
Author: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
Date: Wed Jun 25 17:48:14 2008 -0700

x86: rename setup.c to setup_percpu.c

we lost an asm/efi.h include. (which, a bit illogically, is not implicit
via the existing linux/efi.h include.) Fixed below.

Ingo

-------------->
commit 9faea5db92f5ff3b39e7b66656f847dcb9618caa
Author: Ingo Molnar <mingo@xxxxxxx>
Date: Thu Jun 26 12:02:01 2008 +0200

x86: build fix

fix:

arch/x86/kernel/setup.c: In function âsetup_arch':
arch/x86/kernel/setup.c:561: error: implicit declaration of function âefi_reserve_early'

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index a3f2263..29f04da 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -79,6 +79,7 @@
#include <asm/mpspec.h>
#include <asm/setup.h>
#include <asm/arch_hooks.h>
+#include <asm/efi.h>
#include <asm/sections.h>
#include <asm/dmi.h>
#include <asm/io_apic.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/