Re: [PATCH] x86: check command line when CONFIG_X86_MPPARSE is not set

[Yinghai Lu]

On Tue, Jun 24, 2008 at 5:12 AM, Pavel Machek <pavel@xxxxxxx> wrote:
> Hi!
>
>> we can not use acpi=off, acpi=noirq and pci=noacpi when mps support is
>> not there
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
>>
>> ---
>>  arch/x86/kernel/acpi/boot.c |   12 ++++++++++++
>>  arch/x86/kernel/setup_32.c  |    2 ++
>>  arch/x86/kernel/setup_64.c  |    2 ++
>>  include/linux/acpi.h        |    5 +++++
>>  4 files changed, 21 insertions(+)
>>
>> Index: linux-2.6/arch/x86/kernel/acpi/boot.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/kernel/acpi/boot.c
>> +++ linux-2.6/arch/x86/kernel/acpi/boot.c
>> @@ -1740,6 +1740,18 @@ static int __init parse_pci(char *arg)
>>  }
>>  early_param("pci", parse_pci);
>>
>> +void __init acpi_mps_check(void)
>> +{
>> +#if defined(CONFIG_X86_LOCAL_APIC) && !defined(CONFIG_X86_MPPARSE)
>> +/* mptable code is not built-in*/
>> +     if (acpi_disabled || acpi_noirq) {
>> +             printk(KERN_ERR "MPS support code is not built-in\n",
>> +                    "so can not use acpi=off or acpi=noirq or pci=noacpi\n");
>> +             panic("MPS support is not built-in\n");
>> +     }
>> +#endif
>
> I'd say this is good enough reason not to make X86_MPPARSE optional.
>

new patch in tip/master, it will disable smp instead of panic.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/