Re: [patch 5/5] x86 PCI: use dev_printk when possible

From: Len Brown
Date: Wed Jun 25 2008 - 23:49:28 EST


I guess the 'INTA#; rather than 'INTA' syntax I'm not fond of appears in
this x86 patch too. I think if we don't really have anything useful
to say about polarity, then we should not add an active low symbol.

thanks,
-Len

- printk(KERN_INFO "PCI: %s IRQ %d for device %s\n", msg, irq,
pci_name(dev));
+ dev_info(&dev->dev, "%s PCI INT%c# -> IRQ %d\n", msg, 'A' + pin,
irq);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/