Re: [PATCH] rtc: remove BKL for ioctl()

[Jonathan Corbet]

On Wed, 25 Jun 2008 23:30:17 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> For an ioctl case which should never be blocking for long periods it
> shouldn't be _interruptible in the first place, that will just
> introduce bizarre and weird bugs in application code.

OTOH, my sysadmin youth left me with some painful memories of having to
reboot important systems to get rid of a process with some vital
resource in a D-state death grip.  So I have a certain aversion to
putting uninterruptible waits in places where they aren't really
necessary.

Perhaps this is a good candidate for mutex_lock_killable()?

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/