Re: [PATCH] rtc: remove BKL for ioctl()

From: Jonathan Corbet
Date: Wed Jun 25 2008 - 18:39:46 EST


On Sun, 22 Jun 2008 19:55:42 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> Remove implicit use of BKL in ioctl() from the RTC framework.

Looks good, I'll happily put it into the bkl-removal tree. One
question, though:

> + err = mutex_lock_interruptible(&rtc->ops_lock);
> + if (err)
> + return -EBUSY;
> +

Shouldn't that be -EINTR?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/