Re: [PATCH] PNP: have quirk_system_pci_resources() include ioresources.

From: Andrew Morton
Date: Wed Jun 25 2008 - 17:16:47 EST


On Wed, 25 Jun 2008 19:58:20 +0200
Rene Herman <rene.herman@xxxxxxxxxxxx> wrote:

> + unsigned int type;
> +
> + type = pci_resource_flags(pdev, i) &
> + (IORESOURCE_IO | IORESOURCE_MEM);

pci_resource_flags() returns an unsigned long.

But I think you're right and resource.flags is wrong. Because there's
no way in which we'll ever be able to use bits 32-63 of that field
anyway.

I suppose that Someone(tm) should convert resource.flags to a u32 or
something. Minor issue.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/