Re: [PATCH 1/3] e820_update_range(): Strip size of original region

[Bernhard Walle]

* Yinghai Lu [2008-06-24 12:57]:
>
> On Tue, Jun 24, 2008 at 7:35 AM, Bernhard Walle <bwalle@xxxxxxx> wrote:
> > This patch fixes a bug in e820_update_range(): Previously, if a region was
> > partially covered, then e820_update_range() only added a new E820 range but
> > didn't update the end/size of the previous range. That lead to duplicate
> > covering of a region.
> >
> > Patch tested on i386 and x86-64 with patch that uses e820_update_range()
> > to limit the E820 map when "mem" parameter is specified on the command line.
> >
> >
> > Signed-off-by: Bernhard Walle <bwalle@xxxxxxx>
> > ---
> >  arch/x86/kernel/e820.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> > index e285ea3..e466073 100644
> > --- a/arch/x86/kernel/e820.c
> > +++ b/arch/x86/kernel/e820.c
> > @@ -422,6 +422,7 @@ u64 __init e820_update_range(u64 start, u64 size, unsigned old_type,
> >                final_end = min(start + size, ei->addr + ei->size);
> >                if (final_start >= final_end)
> >                        continue;
> > +               ei->size -= final_end - final_start;
> >                e820_add_region(final_start, final_end - final_start,
> >                                         new_type);
> >                real_updated_size += final_end - final_start;
> > --
> 
> thanks for finding it, but fix is not complete. could have problem
> with fore boundary overlapping. need to update the ei->addr
> 
> please check attached patch

Thanks, works. I added this to my patch series and reposted them.


Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/