Re: [PATCH] maple: tidy maple_driver code by removing redundantconnect/disconnect

From: Paul Mundt
Date: Tue Jun 24 2008 - 16:01:52 EST


On Tue, Jun 24, 2008 at 11:59:07AM +0100, Adrian McMenamin wrote:
> On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> > On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> >> The connect and disconnect functions are unnecessary - everything they
> >> do can be
> >> accomplished in the initial probe - so remove them.
> >>
> >> Signed-off-by: Adrian McMenamin <adrian@xxxxxxxxxxxxxxxxx>
> >
> > Applied, thanks.
> >
> Paul,
>
> Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
> keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
> applied.
>
> I haven't heard back from Dmitry on the keyboard patch yet.
>
Yes, I'm aware of that. This should fix itself in linux-next once it is
merged in the input tree, and I don't intend on pushing my changes until
that's in place, so we don't break bisection.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/