RE: [PATCH 3/14] arch/ia64: Eliminate NULL test and memset afteralloc_bootmem

From: Julia Lawall
Date: Tue Jun 24 2008 - 13:56:01 EST


On Tue, 24 Jun 2008, Luck, Tony wrote:

> > As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b,
> > alloc_bootmem and related functions never return NULL and always return a
> > zeroed region of memory. Thus a NULL test or memset after calls to these
> > functions is unnecessary.
>
> There is no commit b1fceac2b9e04d278316b2faddf276015fc06e3b in Linus' tree.

I am not sure to know how to tell precisely where you are looking, but you
can find it here:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1fceac2b9e04d278316b2faddf276015fc06e3b


> In addition the current alloc_bootmem() is a macro that uses __alloc_bootmem
> which most defintely can return NULL.

The "return NULL;" at the bottom of __alloc_bootmem is preceded by
panic("Out of memory");, which I assume cannot return?

> Is this against -mm or linux-next?

I pull files from the following git repository:

git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

julia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/