RE: [PATCH][resubmit] HP iLO driver

[Altobelli, David]

Pekka Enberg wrote:
>
> The upper case Q is not a proper local variable name (appears
> elsewhere as well).

Okay.

> Static inline functions are preferred over function-like macros.

I'll look at those.  I like macros, but if people feel strongly about
it, I'll convert them.  The ones that shift bits around seem like
macros, but the ones that make function calls should be functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/