Re: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2userspace

[Robert Hancock]

Mark M. Hoffman wrote:
> Linus, Rene, et al:
>
> * Rene Herman <rene.herman@xxxxxxxxxxxx> [2008-06-23 17:06:14 +0200]:
> > drivers/thermal/thermal_sys.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 6098787..c21e03c 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -357,7 +357,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
> >
> > 	INIT_LIST_HEAD(&hwmon->tz_list);
> > 	strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH);
> > -	hwmon->device = hwmon_device_register(NULL);
> > +	hwmon->device = hwmon_device_register(&tz->device);
> > 	if (IS_ERR(hwmon->device)) {
> > 		result = PTR_ERR(hwmon->device);
> > 		goto free_mem;
>
> NACK.
>
> 1) The bug is in libsensors (2.10), not the kernel.

This doesn't matter. Breaking userspace in such a fashion is severely 
frowned upon unless essentially unavoidable, even if it is just 
triggering a bug.

> - but more importantly -
>
> 2) This patch is broken.

You didn't indicate what was wrong with the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/