Re: [git pull] drm patches for 2.6.26-final

From: Johannes Weiner
Date: Fri Jun 20 2008 - 04:55:29 EST


Hi,

Dave Airlie <airlied@xxxxxxxx> writes:

>> There is also an oops fixer reported in the drm ioctl handler.

>> commit 41ee2ff404ec76194315aeed57ac973b010abe1d
>> Author: Johannes Weiner <hannes@xxxxxxxxxxxx>
>> Date: Fri Jun 13 15:04:40 2008 +1000
>>
>> drm: use drms ioctl cmd not what we get passed from userspace.
>>
>> This enforces us to use the drm ioctl types so read/write works correctly and not believe
>> what userspace tells us.
>>
>> It does this hopefully without breaking the drm api.
>>
>> Fixes bug from thread: BUG: unable to handle kernel NULL pointer dereference (drm_getunique)
>>
>> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>

Reported-by: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxxx>

That was only a proposal, to which you did not reply at all [1] and just
silently picked it (without the credits). Not very polite.

Hannes

[1] http://lkml.org/lkml/2008/6/5/250
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/