Re: [PATCH] i386: fix vmalloc_sync_all() for Xen

From: Ingo Molnar
Date: Thu Jun 19 2008 - 08:27:45 EST



* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> >Given that the usermode PGDs will never need syncing, I think it would
> >be better to use KERNEL_PGD_PTRS, and define
> >
> >#define sync_index(a) (((a) >> PMD_SHIFT) - KERNEL_PGD_BOUNDARY)
> >
> >for a massive 192 byte saving in bss.
>
> I was considering that, too, but didn't do so for simplicity's sake.
> If I'll have to re-spin the patch, I may as well do it.

you could do it as a second add-on patch as well - or as a respun patch.
Jeremy, is it now Acked-by you?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/