Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug duringMTU change

From: Francois Romieu
Date: Wed Jun 18 2008 - 16:11:23 EST


Séguier Régis <rseguier@xxxxxxxxxxxxxx> :
[...]
> This correction seems to work.
>
> I read somewhere pci_free_consistent (in velocity_free_dma_rings) couldn't
> be use in a spin_lock.

Yup.

> When I move velocity_free_rings outside the spin_lock, error desappeare but
> data transfert doesn't work after the mtu change.
> When I add velocity_give_many_rx_descs all work.

I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/
accordingly. Can you check whether it is fine or not ?

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/