Re: [patch 12/21] perfmon2 minimal: sysfs interface
From: Greg KH
Date: Wed Jun 11 2008 - 10:51:17 EST
On Mon, Jun 09, 2008 at 03:34:25PM -0700, eranian@xxxxxxxxxxxxxx wrote:
> +
> +static struct kobject pfm_kernel_kobj;
Eeek, no, please look at Documentation/kobject.txt that says to not ever
have static kobjects.
I think a lot of this code can be cleaned up and shrunk given the way
that kobjects have changed recently. See the examples in
samples/kobject/ and the documentation file for more details.
If you have any questions about it, please let me know.
Also, whenever you add a sysfs file to the kernel, please document it in
Documentation/ABI/ so that everyone knows what it is and how to use it.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/