Re: [PATCH] kmemcheck: don't track pages allocated with interrupts disabled

From: Vegard Nossum
Date: Sat Jun 07 2008 - 14:18:20 EST


On Sat, Jun 7, 2008 at 7:12 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> But a far better solution is to just split all the pages in the system
> with set_memory_4k() at boot time (and memory hot add time) when you
> know you're not in interrupt context.
>
> I believe that would be the right solution for DEBUG_PAGEALLOC too.

Ah, this is very true for more than one reason. We only ever touch
kernel pages with kmemcheck. So this means that userspace can still
use large pages and save memory with that. This wouldn't work when we
disable PSE entirely.


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/