Re: [PATCH] kmemcheck: don't track pages allocated with interruptsdisabled

From: Andi Kleen
Date: Sat Jun 07 2008 - 13:13:25 EST


Vegard Nossum wrote:
> It seems that I was wrong regarding the set_memory_4k() approach. It seems
> to only have worked because we were lucky.

You just put it in the wrong place I think.

> We may later reinstate the code
> to disable PSE, but this time not unconditionally, perhaps with a config
> option or boot-time option.

It would be kind of guaranteed (not sure 100%) together with
CONFOG_DEBUG_PAGEALLOC and Thomas' page table pool (the pool is ifdefed
on that)

But a far better solution is to just split all the pages in the system
with set_memory_4k() at boot time (and memory hot add time) when you
know you're not in interrupt context.

I believe that would be the right solution for DEBUG_PAGEALLOC too.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/