Re: [PATCH v2] Add backlight driver for Nvidia-based Apple Macbook Pros

From: Julien BLACHE
Date: Sat Jun 07 2008 - 10:55:14 EST


Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:

Hi,

> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>

If you need it, here you have it:

Signed-off-by: Julien Blache <jb@xxxxxxxxxxx>

Minor nitpicks follow:

> +config BACKLIGHT_MBP_NVIDIA
> + tristate "Macbook Pro Nvidia Backlight Driver"
^^^^^^^
Proper capitalization is "MacBook", also to be consistent with other
help texts in the kernel (I hope).

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

This particular file in pommed is GPL v2 or later; it's external
code I included in pommed and the original license was GPL v2 or
later.

JB.

--
Julien BLACHE <http://www.jblache.org>
<jb@xxxxxxxxxxx> GPG KeyID 0xF5D65169
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/