Re: [PATCH -mm 06/25] split LRU lists into anon & file sets

From: Andrew Morton
Date: Fri Jun 06 2008 - 21:54:26 EST


On Fri, 6 Jun 2008 21:22:31 -0400 Rik van Riel <riel@xxxxxxxxxx> wrote:

> On Fri, 6 Jun 2008 18:04:39 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > The changelogs are a bit scrappy and could do with some care
> >
> > - stale assertions such as the above
> >
> > - "From:<random number of spaces>Lee" in various places
> >
> > - Some have the --- separator and others don't (this trips me up).
> >
> > - Stuff like "Against: 2.6.26-rc2-mm1" right in the middle of the
> > changelog for me to hunt down and squish.
>
> I got rid of all of those - until I merged in Lee's latest :(
>
> > - "TODO: DEBUGGING ONLY: NOT FOR UPSTREAM MERGE" <<-- what's up with this?
>
> I'll remove this one.
>
> > - random Capitalisation in Various patch Titles.
> >
> > - "V2 -> V3:" logging in the main changelog - not relevant in the
> > final commit hence more for me to edit away.
>
> I got rid of all of those - again, before merging Lee's latest.
> Then I got rid of most of them, but apparently missed a few...

Poeple often maintain that sort of info below the ^--- line.

>
...
>
> > Do we really want to put all this stuff into /proc/meminfo?
> >
> > Would it be better to aggregate it in some manner for meminfo and show
> > the fine-grained info in /proc/vmstat?
>
> Good question. I believe we'll want the memory usage statistics
> in /proc/meminfo, but more temporary internal stuff like
> "writebacktmp" and "nfs_unstable" might not belong there.

Well, I was just asking.. I haven't actually sat down and worked out
what the proposed new meminfo will look like yet.

(It's documented in Documentation/filesystems/proc.txt btw. Or used
to be ;))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/