Re: [PATCH -mm 10/25] add newly swapped in pages to the inactivelist

From: Andrew Morton
Date: Fri Jun 06 2008 - 21:07:59 EST


On Fri, 06 Jun 2008 16:28:48 -0400
Rik van Riel <riel@xxxxxxxxxx> wrote:

> From: Rik van Riel <riel@xxxxxxxxxx>
>
> Swapin_readahead can read in a lot of data that the processes in
> memory never need. Adding swap cache pages to the inactive list
> prevents them from putting too much pressure on the working set.
>
> This has the potential to help the programs that are already in
> memory, but it could also be a disadvantage to processes that
> are trying to get swapped in.
>
> In short, this patch needs testing.
>

<hopes that the changelog is out of date>

>
> ---
> mm/swap_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.26-rc2-mm1/mm/swap_state.c
> ===================================================================
> --- linux-2.6.26-rc2-mm1.orig/mm/swap_state.c 2008-05-28 09:40:59.000000000 -0400
> +++ linux-2.6.26-rc2-mm1/mm/swap_state.c 2008-05-28 09:42:26.000000000 -0400
> @@ -302,7 +302,7 @@ struct page *read_swap_cache_async(swp_e
> /*
> * Initiate read into locked page and return.
> */
> - lru_cache_add_active_anon(new_page);
> + lru_cache_add_anon(new_page);
> swap_readpage(NULL, new_page);
> return new_page;
> }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/