Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ProtectionSystem 3D ACPI driver -- please review!

From: Pau Oliva Fora
Date: Fri Jun 06 2008 - 11:31:20 EST


Eric Piel wrote:
Pau Oliva Fora wrote:
Here's an i2c version of the driver for the LIS3LV02DL accelerometer,
please try to combine it too, so we'll end up having ACPI, SPI and I2C.
Whaoo, you went fast!
As there is a dmi_match, that shouldn't be too hard to incorporate it nicely :-)

BTW, do you really need the invert_x and invert_y and swap_xy parameters? Don't all the HTC shift laptops have the sensors soldered the same way? We've worked hard to remove those parameters in mdps ;-)


Yes, you can remove the module params, and use the same approach you have based in DMI table.

Cheers,

Pau Oliva
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/