Re: [PATCH 1/4] pagemap: Require reads of /proc/pid/pagemap to bemultiples of 8 (v2 of series)

From: Andrew Morton
Date: Thu Jun 05 2008 - 15:38:32 EST


On Thu, 5 Jun 2008 14:38:10 -0400
"Thomas Tuttle" <ttuttle@xxxxxxxxxx> wrote:

> This matches the behavior of /proc/kpage{count,flags}, and simplifies
> the logic a bit.
>
> I also changed out and end in struct pagemapread to be u64* instead of
> char*, which makes put_user work the way it was intended. (Before, it
> was only copying the bottom byte of a pagemap entry, because the target
> of the copy was a char*.)

This one is for 2.6.25.x?

Is so, the maintainers are going to wonder why the heck we sent it to
them. It does fix a bug, but it is far from clear what that bug is.

Can we have a better description please?

> Signed-off-by: Thomas Tuttle

Please include <ttuttle@xxxxxxxxxx> in the signoffs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/