Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_userinstead of put_user.

[Matt Mackall]

On Thu, 2008-06-05 at 12:02 -0700, Andrew Morton wrote:
> On Thu, 5 Jun 2008 11:04:21 -0400
> "Thomas Tuttle" <ttuttle@xxxxxxxxxx> wrote:
> 
> > While fiddling with pagemap, I discovered a bug in add_to_pagemap.
> 
> so...  afaict we have some fairly significant problems in here and a
> version 2 of the patchset is in order?
> 
> If so, when preparing that patchset please do have a think about which
> of the fixes you believe should be backported into 2.6.25.x and prepare
> the patches so that those fixes come first, to ease that backporting.

For 2.6.25.x, we should probably just add a cast to the put_user dest.
Thomas?

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/