Re: [PATCH] FRV: ip_fast_csum() requires a memory clobber on its inline asm

[Matthew Wilcox]

On Thu, Jun 05, 2008 at 05:07:35PM +0100, David Howells wrote:
>  	    : "=r" (sum), "=r" (iph), "=r" (ihl), "=r" (inc), "=&r"(tmp)
>  	    : "0" (sum), "1" (iph), "2" (ihl), "3" (4),
>  	    "m"(*(volatile struct { int _[100]; } *)iph)

Do you still need the input "m" constraint?

> -	    : "icc0", "icc1"
> +	    : "icc0", "icc1", "memory"
>  	    );
>  
>  	return (__force __sum16)~sum;

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/