Re: RFC [PATCH] x86: make generic arch support NUMAQ

From: Yinghai Lu
Date: Thu Jun 05 2008 - 13:33:56 EST


On Thu, Jun 5, 2008 at 5:39 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
>> > +#if defined(CONFIG_X86_NUMAQ) || defined(CONFIG_X86_GENERICARCH)
>>
>> I counted several places where you test for the above. Introducing a
>> CONFIG_X86_NUMAQ_OR_GENERIC would simplify stuff.
>
> Yinghai, please get rid of the NUMAQ build option altogether and
> eliminate the subarch.
>
> We should keep a compatibility CONFIG_X86_NUMAQ that selects
> X86_GENERICARCH, so that 'make oldconfig' on a NUMAQ config does the
> right thing - but it's not a subarch anymore nor anything
> user-configurable.

how about the Summit, and ES7000? You still have the two entries for them.

Anyway, will remove entry in the list and make CONFIG_X86_NUMAQ select
X86_GENERICARCH

and make the those ifdef only use X86_GENERICARCH...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/