RE: [PATCH] spi: fix list scan success verification in PXA ssp driver

[Eric Miao]

Acked-by: Eric Miao <eric.miao@xxxxxxxxxxx>

And this should really go through the ARM tree, please submit the patch
to RMK's patch system. Thanks.

Cheers
- eric

> -----Original Message-----
> From: Guennadi Liakhovetski [mailto:g.liakhovetski@xxxxxxxxxxxxxx]
> Sent: Thursday, June 05, 2008 4:37 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: dbrownell@xxxxxxxxxxxxxxxxxxxxx; Eric Miao;
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver
> 
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxxxxxxxxxx>
> 
> ---
> 
>  arch/arm/mach-pxa/ssp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:26.000000000
> +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
> 
>  	mutex_unlock(&ssp_lock);
> 
> -	if (ssp->port_id != port)
> +	if (&ssp->node == &ssp_list)
>  		return NULL;
> 
>  	return ssp;

N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i