Re: [PATCH 0/5] page reclaim throttle v7

[KOSAKI Motohiro]

Hi kame-san,

> I like this series and I'd like to support this under memcg when
> this goes to mainline. (it seems better to test this for a while
> before adding some memcg-related changes.)
> 
> Then, please give me inputs.
> What do you think do I have to do for supporting this in memcg ?
> Handling the case of scan_global_lru(sc)==false is enough ?

my patch have 2 improvement.
1. ristrict reclaiming parallerism of #task (throttle)
2. reclaiming cut off if other task already freed enough memory.

we already consider #1 on memcg and works well.
but we doesn't support #2 on memcg because balbir-san's said
"memcg doesn't need it".

if you need improvement of #2, please change blow portion of my patch.

> +	/* reclaim still necessary? */
> +	if (scan_global_lru(sc) &&
> +	    freed - sc->was_freed >= threshold) {
> +		if (zone_watermark_ok(zone, sc->order, zone->pages_high,
> +				      gfp_zone(sc->gfp_mask), 0)) {
> +			ret = -EAGAIN;
> +			goto out;
> +		}
> +		sc->was_freed = freed;
> +	}
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/