Re: [PATCH 2/2] cpusets: update tasks' cpus_allowed andmems_allowed after CPU/NODE offline/online

From: Paul Jackson
Date: Wed Jun 04 2008 - 15:25:55 EST


David wrote:
> That would only identify kthreads that have been created with a subsequent
> call to set_cpus_allowed() or kthread_bind().
>
> The PF_CPU_BOUND change targets only the latter since there are kthreads,
> such as kstopmachine, that can continue to manipulate their cpus_allowed
> during their lifetime.

Would your first sentence be more clearly written as:

> That would identify both kthreads that have been created with a subsequent
> call to set_cpus_allowed() or kthread_bind().

Or do I misunderstand?

If I am reading you correctly, then would it work to have a check in the
cpuset code (rather than in the lower set_cpus_allowed() routine),
where that check refused to move tasks out of the root cpuset if they
were (1) kernel threads (mm NULL) and (2) had cpus_allowed that were a
strict subset of the root cpusets 'cpus' (the online cpus).

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/