Re: [PATCH 1/2] lib: export bitrev16

[Akinobu Mita]

> --- a/lib/bitrev.c
> +++ b/lib/bitrev.c
> @@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
>  };
>  EXPORT_SYMBOL_GPL(byte_rev_table);
>
> -static __always_inline u16 bitrev16(u16 x)
> +u16 bitrev16(u16 x)
>  {
>        return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
>  }
> +EXPORT_SYMBOL(bitrev16);

How about just moving bitrev16() from lib/bitrev.c to include/linux/bitrev.h
with s/__always_inline/inline/ rather than making it export symbol?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/