Re: AT91SAM9/CAP9 watchdog driver

From: Alan Cox
Date: Wed Jun 04 2008 - 07:52:53 EST


On Wed, 4 Jun 2008 09:31:50 +0200
"Andrew Victor" <avictor.za@xxxxxxxxx> wrote:

> hi Andrew,
>
> >> + return 0;
> >
> > That looks like the wrong return value?
>
> Since the watchdog registers are Write-Once, if the user does not
> specify a "wdt_timeout" parameter we'd still like the driver to load
> even if it's not enabled.

Surely you can avoid doing the register writes until after you check the
validity of arguments ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/