Re: [PATCH] utimensat() non-conformances and fixes [v3]

From: Al Viro
Date: Tue Jun 03 2008 - 07:22:45 EST


On Tue, Jun 03, 2008 at 01:13:00PM +0200, Miklos Szeredi wrote:
> > > I'm not sure of the correct way to get the required nameidata (to do a
> > > vfs_permission() call) from the file descriptor. Can you give me a
> > > tip there?
> >
> > Could you point me at the right way of doing this?
>
> You don't need nameidata for this at all. Just call permission() with
> a NULL nameidata.
>
> Ugly API? Yes, will be cleaned up if we manage to find some common
> ground with the VFS maintainers.

As soon as I'm done with sysctls...

FWIW, I very much doubt that you are right wrt required permissions, though.
AFAICS, intent here is "if you can write to file, you can touch the timestamps
anyway" and having descriptor opened for write gives that, current permissions
be damned.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/