Re: [PATCH 6/7] disable pci legacy boot irq quirks on noapic boot

From: Thomas Gleixner
Date: Tue Jun 03 2008 - 06:55:42 EST


On Mon, 2 Jun 2008, Olaf Dabrunz wrote:

> From: Stefan Assmann <sassmann@xxxxxxx>
>
> Don't enable pci boot irq quirks when falling back to pic, this would
> break interrupt routing.
>
> Signed-off-by: Stefan Assmann <sassmann@xxxxxxx>
> Signed-off-by: Olaf Dabrunz <od@xxxxxxx>
> ---
> include/asm-x86/io_apic.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-x86/io_apic.h b/include/asm-x86/io_apic.h
> index 5b1292f..461771c 100644
> --- a/include/asm-x86/io_apic.h
> +++ b/include/asm-x86/io_apic.h
> @@ -151,8 +151,11 @@ extern int skip_ioapic_setup;
> /* 1 if the timer IRQ uses the '8259A Virtual Wire' mode */
> extern int timer_through_8259;
>
> +extern int nobootirqquirk;
> +

declarations in headers please.

> static inline void disable_ioapic_setup(void)
> {
> + nobootirqquirk = 1;

This logic needs to be default disabled anyway.

> skip_ioapic_setup = 1;
> }
>
> --
> 1.5.2.4
>
> --
> Olaf Dabrunz (od/odabrunz), SUSE Linux Products GmbH, N??rnberg
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/