Re: [PATCH] x86: Add PCI extended config space access for AMDBarcelona

[Robert Richter]

On 02.06.08 13:31:38, Yinghai Lu wrote:
> > +               if (!raw_pci_ext_ops && cpu_has_pci_ext_cfg) {
> > +                       printk(KERN_INFO "PCI: Using configuration type 1 "
> > +                              "for extended access\n");
> > +                       raw_pci_ext_ops = &pci_direct_conf1;
> 
> can you add extra pci_direct_ext_conf1 intead?
> 
> so don't need change reg size in pci_direct_conf1

The reg size check is already in raw_pci_*. Both functions would be
almost identical. See my previous mail.

> also if could avoid cpu_has_pci_ext_cfg, it would be great...

I intend to implement pci_probe & PCI_HAS_EXT_CFG in a follow on patch
instead.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/