Re: [PATCH] vmallocinfo: Add NUMA informations

From: KOSAKI Motohiro
Date: Tue Jun 03 2008 - 00:35:52 EST


> >> + for (nr = 0; nr < MAX_NUMNODES; nr++)
> >> + if (counters[nr])
> >> + seq_printf(m, " N%u=%u", nr, counters[nr]);
> >
> > for_each_node_state(n, N_HIGH_MEMORY) is better?
> > because MAX_NUMNODES has offten very large value.
> >
> Yes, good idea, thank you.
>
> I also used nr_node_ids instead of MAX_NUMNODES in this second version :

Thank you! looks goot to me.
and, my test fouund no bug.

Tested-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>


Cristoph, What do you think?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/