Re: [PATCH] sched: CPU hotplug events must not destroy schedulerdomains created by the cpusets

From: Max Krasnyansky
Date: Mon Jun 02 2008 - 15:01:20 EST


Paul Jackson wrote:

> How about:
> 1) Defining arch_init_sched_domains() for all CONFIGs, CPUSET or not
> (see for example how free_sched_groups() is defined, NUMA or not)
> 2) Then the ifndef can be removed from here.
> 3) Then the arch_init_sched_domains() can be moved comfortably inside
> the switch statement.

Paul, I just realized that this won't work. We actually need the default
version of arch_init_sched_domains() which builds the default domain. It's
used during bootup. It's only the hotplug event handling where we do not want
the default.
I could still redo the switch() statement as you suggested but it seems that
it's not going to improve the readability that much at this point.

Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/