Re: [PATCH] ata: ahci: power off unused ports

From: Jeff Garzik
Date: Mon Jun 02 2008 - 14:15:47 EST


Kristen Carlson Accardi wrote:
Here you can see that it would be very easy for another driver
to just add code to set the NO_HOTPLUG flag and then this code
will work for them as well, since we power off the phy using
DET which is specified by SATA.

here's that code:

Agreed. The main discussion in this sub-thread is more about user interface. The user interface in this case, a module option, is specific to AHCI.

Surely you can see how it is a bit silly to force each driver writer to create the same user interface in each driver, to support a generic concept.

Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/