Re: [patch 00/15] PNP: convert resource options to unified dynamic list, v1

[Bjorn Helgaas]

On Sunday 01 June 2008 01:28:23 pm Rene Herman wrote:
> On 31-05-08 00:48, Bjorn Helgaas wrote:
> 
> > This patch series converts the PNP resource option structures
> > to a unified linked list.  This preserves resource order, which
> > is important for some devices.  There's more detail in the
> > comments for the last patch.
> > 
> > Any comments would be welcome.
> > 
> > This depends on some patches that are in -mm, but not yet
> > upstream.  In mmotm, these would probably go after
> > pnp-dont-sort-by-type-in-sys-resources.patch
> 
> Will look at this in more detail but as first testing feedback -- I need 
> this on top.
> 
> Both ISAPnP and PnPBIOS for some or other reason set the priority to 
> 0x100 | prio after which that 0x100 is immediately masked of again in 
> pnp_build_option() leaving just the prio. Your new scheme reserves 16 
> bits for the priority though meaning the 0x100 survives causing it to be 
> considered "invalid" by at least pnp_option_priority_name() for example.
> 
> There cannot be any currently valid reason for the 0x100 it seems given 
> that it's immediately masked of again in pnp_build_option() so let's 
> just get rid of it...

I agree, that bit looks superfluous.  I added a patch to remove it.
Thanks,
  Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/