Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core

[Yasunori Goto]

> Hi,
> 
> Yasunori Goto <y-goto@xxxxxxxxxxxxxx> writes:
> 
> > Hello.
> >
> >> +		/*
> >> +		 * Reserve the area now:
> >> +		 */
> >> +		for (i = PFN_DOWN(new_start) + merge; i < PFN_UP(new_end); i++)
> >> +			if (test_and_set_bit(i, bdata->node_bootmem_map))
> >> +				BUG();
> >> +
> >> +		region = phys_to_virt(bdata->node_boot_start + new_start);
> >> +		memset(region, 0, size);
> >> +		return region;
> >
> > bdata->last_success doesn't seem to be updated in alloc_bootmem_core(),
> > it is updated in only __free().
> > Is it intended? If not, it should be updated, I suppose....
> 
> Yeah, I forgot that.  See my reply to `bootmem: respect goal more
> likely'.
> 
> Thanks for reviewing!
> 
> 	Hannes

Oh, I didn't notice it.
Ok. I'll test newer version on my ia64 box.


Bye.


-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/