Re: [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_start/commit

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>
>   
> > +#define  __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION
> >     
>
> please turn this into CONFIG_ARCH_HAS_PTEP_MODIFY_PROT_TRANSACTION 
> instead.

The __HAVE_ARCH_ form is consistent with all the other conditional 
things in asm/pgtable.h, like __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS, 
__HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG, etc.  I don't think adding 
CONFIG_ARCH_HAS_ for this one case is a good idea.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/