Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transactionabstraction
From: Ingo Molnar
Date: Mon Jun 02 2008 - 07:14:46 EST
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> + /* Get the current pte state, but zero it out to make it
> + non-present, preventing the hardware from asynchronously
> + updating it. */
please use standard and consistent comment style, similar to:
> +/*
> + * Start a pte protection read-modify-write transaction, which
> + * protects against asynchronous hardware modifications to the pte.
> + * The intention is not to prevent the hardware from making pte
> + * updates, but to prevent any updates it may make from being lost.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/